Update CI workflow to save benchmark output and check results with jq #525
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catatsuy
deleted the
feature-update-ci-workflow-add-benchmark-output-check
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the CI workflow to capture and check benchmark results more effectively. The most important changes include modifying the benchmark command to save the output to a JSON file and adding a step to check the benchmark result.
Changes to CI workflow:
benchmark_output.jsonfile. (.github/workflows/ci.yml, .github/workflows/ci.ymlL97-R101)benchmark_output.jsonfile and setting theBENCHMARK_FAILEDenvironment variable if the benchmark did not pass. (.github/workflows/ci.yml, .github/workflows/ci.ymlL97-R101)