Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor image and post link extraction to use iter #535

Merged
merged 1 commit into from
Sep 8, 2024

Conversation

catatsuy
Copy link
Owner

@catatsuy catatsuy commented Sep 8, 2024

This pull request includes changes to the benchmarker module, focusing on improving the build process and optimizing image and post link extraction. The most important changes are as follows:

Build process improvements:

  • benchmarker/Makefile: Updated the build target bin/benchmarker to include go.mod and go.sum files, ensuring all dependencies are considered during the build process.

Code optimization:

  • benchmarker/scenario.go: Optimized the extractImages and extractPostLinks functions by preallocating slices with a capacity of PostsPerPage and replacing the .Each method with .EachIter for better performance.

@catatsuy catatsuy merged commit 2cf9b3d into master Sep 8, 2024
4 checks passed
@catatsuy catatsuy deleted the refactor-extract-images-and-post-links-using-iter branch September 8, 2024 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant