Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: push api logic into the app #158

Merged
merged 12 commits into from
Apr 25, 2024
Merged

refactor: push api logic into the app #158

merged 12 commits into from
Apr 25, 2024

Conversation

cbochs
Copy link
Owner

@cbochs cbochs commented Apr 25, 2024

User-facing Changes

  • Fix issue where GrappleUpdate was being triggered too often
    • Grapple.{tag,untag,toggle,select,cycle_tags trigger GrappleUpdate
    • Grapple.{find,exists,tags} do not trigger GrappleUpdate
  • Add scope_id?: string to available top-level Grapple options
  • Deprecate Grapple.clear_cache

Other Changes

  • Move Grapple.initialize entirely into plugin/grapple.lua
  • Move most top-level API logic into app, improving abractions
  • Add smoke test spec for top-level Grapple API
  • Move Grapple "transaction" out of the tag manager and into app
  • Remove app dependency for both scope and tag managers

@cbochs cbochs mentioned this pull request Apr 25, 2024
Closed
@cbochs cbochs merged commit 4519469 into main Apr 25, 2024
3 of 4 checks passed
@cbochs cbochs deleted the fix/user_events branch April 25, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cbochs