Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update header comments & documentation #791

Merged
merged 1 commit into from
May 12, 2020

Conversation

robertmryan
Copy link
Collaborator

I noticed that the inline documentation, which was tailored for appledoc, didn’t render well within Xcode. For example, the documentation for FMDatabaseQueue looked like:

Screen Shot 2020-05-08 at 3 51 11 PM (2)

With this PR, it is now rendered like so:

Screen Shot 2020-05-08 at 3 50 21 PM (2)

Bottom line, I’ve wrapped code blocks with @code/@endcode, replaced back ticks with @c tags, etc. I’ve also fixed some problems (e.g. a #pragma between the comment and the @interface was preventing documentation from showing up; a private method that shouldn’t have been exposed has been hidden; etc.).

In full disclosure, I didn’t do much review of the content of the documentation, but focused largely on the formatting only. Also, this was a fairly cursory cleanup and I’m sure it’s not perfect, but it’s much better, IMHO.

Assuming you’re good with these fixes, I’d suggest rebuilding the gh-pages documentation, but rather than using appledoc (which doesn’t appear to have been updated in a very long time), I’ve found jazzy to be a little more up to date with modern auto-documenting conventions. I’ll do separate PR for that (if and when you approve this PR).

@robertmryan robertmryan mentioned this pull request May 9, 2020
@ccgus ccgus merged commit 61e51fd into master May 12, 2020
@ccgus
Copy link
Owner

ccgus commented May 12, 2020

Thanks for doing this! And of course, I merged the patches out of order I think? (That's just the way I roll)

@robertmryan
Copy link
Collaborator Author

@ccgus - No problem. I’m willing to stick a fork in 2.7.7. Do you mind if I tag it as a release (for Carthage users) and push the trunk to Cocoapods (assuming I even have that permission)? Or is there anything else you want to include in 2.7.7 before we do that?

@robertmryan robertmryan deleted the robertmryan/update-documentation branch May 12, 2020 17:52
@ccgus
Copy link
Owner

ccgus commented May 12, 2020

Yep, go ahead and push it on up. There's nothing else I want to include right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants