Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚚 Move from Cirrus CI back to GitHub Actions #553

Merged
merged 4 commits into from
Feb 21, 2024

Conversation

burgholzer
Copy link
Member

@burgholzer burgholzer commented Feb 14, 2024

Description

Since recently, GitHub finally provides native Apple Silicon runners. This allows us to solely rely on GitHub Actions for running all CI/CD for our projects and to not rely on Cirrus CI for parts of the jobs.
This also means that trusted publishing is now used for all PyPI uploads 🎉
Additionally, after this change, there is only one script uploading all the wheels which creates a single point of failure.
This avoids situations where, e.g., the Cirrus CI build would succeed and upload the wheels, but the GitHub job failed; creating a broken release.

For the time being, we will just run macOS-13 (Intel) and macOS-14 (Apple Silicon) in parallel to test support for both systems.
Sometime in the future, Intel support will most likely be removed.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@burgholzer burgholzer added github_actions Pull requests that update Github_actions code continuous integration Anything related to the CI setup labels Feb 14, 2024
@burgholzer burgholzer self-assigned this Feb 14, 2024
@burgholzer
Copy link
Member Author

I manually triggered the CD job on this branch. The respective results can be found here: https://github.com/cda-tum/mqt-core/actions/runs/7898695928

@burgholzer
Copy link
Member Author

This is currently blocked on actions/setup-python#808, since Python 3.8 is not available via setup-python at the moment.

Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
@burgholzer
Copy link
Member Author

Just worked around the non-existing Python versions for now by excluding them from the tests. This way, the progress on this is not stalled.

@burgholzer burgholzer merged commit f0c7e6a into main Feb 21, 2024
37 checks passed
@burgholzer burgholzer deleted the move-cirrus-ci-to-github branch February 21, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
continuous integration Anything related to the CI setup github_actions Pull requests that update Github_actions code
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant