Check for equality to avoid double parsing some query params

package.json

@@ -56,6 +56,7 @@
     "coveralls": "^3.0.5",
     "deasync": "^0.1.16",
     "express": "^4.17.1",
+    "get-port": "^5.0.0",
     "mocha": "^6.2.0",
     "morgan": "^1.9.1",
     "nodemon": "^2.0.0",

src/middlewares/openapi.request.validator.ts

@@ -156,6 +156,22 @@ export class RequestValidator {
        */
       parameters.parseJson.forEach(item => {
         if (item.reqField === 'query' && queryParamsToValidate[item.name]) {
+          if (queryParamsToValidate[item.name] === req[item.reqField][item.name]) {
+            queryParamsToValidate[item.name] = req[item.reqField][item.name] = JSON.parse(
+              queryParamsToValidate[item.name],
+            );
+
+            /**
+             * The query param we parse and the query param express
+             * parsed are the same value, so we assign them the same
+             * parsed value.
+             */
+            return;
+          }
+          /**
+           * They query params are not the same, so we parse the
+           * `queryParamsToValidate` and don't return.
+           */
           queryParamsToValidate[item.name] = JSON.parse(
             queryParamsToValidate[item.name],
           );
@@ -175,6 +191,13 @@ export class RequestValidator {
        */
       parameters.parseArray.forEach(item => {
         if (item.reqField === 'query' && queryParamsToValidate[item.name]) {
+          if (queryParamsToValidate[item.name] === req[item.reqField][item.name]) {
+            queryParamsToValidate[item.name] = req[item.reqField][item.name] = queryParamsToValidate[item.name].split(
+              item.delimiter,
+            );
+
+            return;
+          }
           queryParamsToValidate[item.name] = queryParamsToValidate[item.name].split(
             item.delimiter,
           );

test/openapi.spec.ts

@@ -1,6 +1,7 @@
 import * as path from 'path';
 import { expect } from 'chai';
 import * as request from 'supertest';
+import * as getPort from 'get-port';
 import { createApp } from './common/app';
 import * as packageJson from '../package.json';
 
@@ -11,13 +12,15 @@ describe(packageJson.name, () => {
   before(() => {
     const apiSpecPath = path.join('test', 'resources', 'openapi.yaml');
     const apiSpecJson = require('./resources/openapi.json');
-    return Promise.all([
-      createApp({ apiSpec: apiSpecPath }, 3001),
-      createApp({ apiSpec: apiSpecJson }, 3002),
-    ]).then(([a1, a2]) => {
-      apps.push(a1);
-      apps.push(a2);
-      basePath = (<any>a1).basePath;
+    return Promise.all([getPort(), getPort()]).then(ports => {
+      return Promise.all([
+        createApp({ apiSpec: apiSpecPath }, ports[0]),
+        createApp({ apiSpec: apiSpecJson }, ports[1]),
+      ]).then(([a1, a2]) => {
+        apps.push(a1);
+        apps.push(a2);
+        basePath = (<any>a1).basePath;
+      });
     });
   });