Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove most of libs/rand #284

Merged
merged 28 commits into from
Apr 21, 2021
Merged

Remove most of libs/rand #284

merged 28 commits into from
Apr 21, 2021

Commits on Apr 17, 2021

  1. Remove unused Time and Int16

    @liamsi
    liamsi committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    0504b9d View commit details
    Browse the repository at this point in the history

  2. remove Uint which was just a cast and remove some tmrand calls on the… 

    … way
    @liamsi
    liamsi committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    fb74903 View commit details
    Browse the repository at this point in the history

  3. remove Uint16

    @liamsi
    liamsi committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    1b498f8 View commit details
    Browse the repository at this point in the history

  4. remove Bool

    @liamsi
    liamsi committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    b099de4 View commit details
    Browse the repository at this point in the history

  5. remove Time on Rand as well

    @liamsi
    liamsi committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    781f6c8 View commit details
    Browse the repository at this point in the history

  6. Use math/rand for Bytes()

    @liamsi
    liamsi committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    59c145c View commit details
    Browse the repository at this point in the history

  7. remove Float32

    @liamsi
    liamsi committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    9af911e View commit details
    Browse the repository at this point in the history

  8. Cleanup the remaining places

    @liamsi
    liamsi committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    9b8bd0f View commit details
    Browse the repository at this point in the history

  9. Review feedback: add clarifying comment 

    Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
    @liamsi @ValarDragon
    liamsi and ValarDragon committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    4833314 View commit details
    Browse the repository at this point in the history

  10. Add clarifying comment that NewRand isn't safe for concurrent use

    @liamsi
    liamsi committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    66e4710 View commit details
    Browse the repository at this point in the history

  11. Add Reseed method as a convenient way to reseed math/rand's default S… 

    …ource
    @liamsi
    liamsi committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    e6c824e View commit details
    Browse the repository at this point in the history

  12. Use math/rand's thread-safe Source in pex instead

    @liamsi
    liamsi committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    ee49c68 View commit details
    Browse the repository at this point in the history

  13. Reseed math/rand's source for p2p.Switch

    @liamsi
    liamsi committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    63823df View commit details
    Browse the repository at this point in the history

  14. make it explicit that the usages of math/rand and tmrand are intentio… 

    …nally not cryptographically secure:

// nolint:gosec // G404: Use of weak random number generator
    @liamsi
    liamsi committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    01bae27 View commit details
    Browse the repository at this point in the history

  15. add a few missed nolints

    @liamsi
    liamsi committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    8922c21 View commit details
    Browse the repository at this point in the history

  16. panic in the almost impossible case that we don't have enough entropy… 

    … to read from OS randomness at this point
    @liamsi
    liamsi committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    b5b94b7 View commit details
    Browse the repository at this point in the history

  17. remaining lints

    @liamsi
    liamsi committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    c14146e View commit details
    Browse the repository at this point in the history

  18. actually appease the linter

    @liamsi
    liamsi committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    7495931 View commit details
    Browse the repository at this point in the history

  19. actually appease the linter 2.0

    @liamsi
    liamsi committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    8c0aeb3 View commit details
    Browse the repository at this point in the history

  20. fix merge glitches

    @liamsi
    liamsi committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    36b44fb View commit details
    Browse the repository at this point in the history

  21. fix test & lint glichtes (while merging)

    @liamsi
    liamsi committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    d604163 View commit details
    Browse the repository at this point in the history

  22. fix another test

    @liamsi
    liamsi committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    0767632 View commit details
    Browse the repository at this point in the history

  23. relax timeouts here too

    @liamsi
    liamsi committed Apr 17, 2021
    Configuration menu
    Copy the full SHA
    e81881c View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2021

  1. Update p2p/switch.go 

    Co-authored-by: Callum Waters <cmwaters19@gmail.com>
    @liamsi @cmwaters
    liamsi and cmwaters committed Apr 19, 2021
    Configuration menu
    Copy the full SHA
    a910e47 View commit details
    Browse the repository at this point in the history

  2. Apply review feedback: use mrand.Uint32() + 1 for height 

    use mrand.Uint32() + 1 for height
    @liamsi
    liamsi committed Apr 19, 2021
    Configuration menu
    Copy the full SHA
    035711c View commit details
    Browse the repository at this point in the history

  3. go fmt

    @liamsi
    liamsi committed Apr 19, 2021
    Configuration menu
    Copy the full SHA
    edc9cb3 View commit details
    Browse the repository at this point in the history

  4. Update comment to reflect current state of Bytes/Str functions

    @liamsi
    liamsi committed Apr 19, 2021
    Configuration menu
    Copy the full SHA
    e70c207 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2021

  1. Merge remote-tracking branch 'origin/master' into ismail/ll/remove_li… 

    …bs-rand

# Conflicts:
#	test/maverick/consensus/wal_generator.go
    @liamsi
    liamsi committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    bb3bcbe View commit details
    Browse the repository at this point in the history