feat(share/getter) Add support for Non-inclusion proofs #2256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walldiss
force-pushed
the
non_inclusion_proofs_integration
branch
from
9fe8e73
to
8128c04
Compare
# Conflicts: # share/get_test.go # share/ipld/get.go # share/ipld/namespace_data.go
walldiss
requested review from
renaynay,
Wondertan,
vgonkivs and
distractedm1nd
as code owners
walldiss
commented
Jun 16, 2023
Wondertan
reviewed
Jun 16, 2023
This was referenced Jun 16, 2023
walldiss
force-pushed
the
non_inclusion_proofs_integration
branch
from
93a356c
to
4bce3ea
Compare
walldiss
force-pushed
the
non_inclusion_proofs_integration
branch
from
5052044
to
2046250
Compare
Wondertan
reviewed
Jun 19, 2023
Codecov Report
@@ Coverage Diff @@
## main #2256 +/- ##
==========================================
+ Coverage 50.48% 50.60% +0.12%
==========================================
Files 157 157
Lines 9933 9925 -8
==========================================
+ Hits 5015 5023 +8
+ Misses 4472 4455 -17
- Partials 446 447 +1
|
Wondertan
requested changes
Jun 20, 2023
walldiss
force-pushed
the
non_inclusion_proofs_integration
branch
from
c54d9c4
to
11c71db
Compare
Wondertan
reviewed
Jun 21, 2023
renaynay
reviewed
Jun 21, 2023
renaynay
approved these changes
Jun 21, 2023
Wondertan
approved these changes
Jun 21, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 27, 2023
## Notable Changes - `namespace.ID` to `share.Namespace` - Changes every comment namespace ID mentioning to just namespace. I renamed every such mention besides in ADRs. I don't want to touch ADRs here, as they need a more holistic re-review and up-to-date catchup. - Uses all the utility methods on the type, where suitable - Namespace constructor now only creates Blob Namespaces. For other reserved namespaces, the predefined globals should be used. - Uses namespace.ValidateDataNamespace everywhere data is requested. This is guarantees we verify the namespace are 100% valid and forbids requesting parity and padding namespaces. - Restricts PFBs for reserved namespaces - Reversed the dependency from `share -> share/ipld` to `share/ipld -> share` - NewBlobV0 constructor. Similar to NewNamespaceV0 - `sharetest` pkg for share related testing utilities - `edstest` pkg for eds related testing utilities ## Follow-ups - `blobtest` pkg to generate node's blob type ## Refs * Substitutes zombie PR #2376. I push to the branch, but GH does not see commits. * Based on #2367 * Closes #2301 * Closes #2309 * Blocked on #2256
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR implements support for non-inclusion proof for getters and shrex protocol.
Requires #2242 to be merged first