Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(state): extend error handling in core accessor #2307

Merged
merged 6 commits into from
Jun 5, 2023

Conversation

vgonkivs
Copy link
Member

@vgonkivs vgonkivs commented Jun 2, 2023

Overview

Extend error handling in core accessor

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@vgonkivs vgonkivs added area:state Related to fetching state and state execution kind:chore labels Jun 2, 2023
@vgonkivs vgonkivs self-assigned this Jun 2, 2023
renaynay
renaynay previously approved these changes Jun 2, 2023
blob/service.go Outdated Show resolved Hide resolved
state/helpers.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2023

Codecov Report

Merging #2307 (03678c4) into main (a01d0b5) will decrease coverage by 0.40%.
The diff coverage is 58.36%.

@@            Coverage Diff             @@
##             main    #2307      +/-   ##
==========================================
- Coverage   50.89%   50.50%   -0.40%     
==========================================
  Files         150      154       +4     
  Lines        9252     9732     +480     
==========================================
+ Hits         4709     4915     +206     
- Misses       4147     4388     +241     
- Partials      396      429      +33     
Impacted Files Coverage Δ
api/gateway/availability.go 0.00% <ø> (ø)
api/gateway/header.go 0.00% <ø> (ø)
api/gateway/state.go 0.00% <0.00%> (ø)
core/testing.go 91.86% <ø> (-0.10%) ⬇️
core/testing_grpc.go 65.07% <ø> (ø)
das/daser.go 64.83% <0.00%> (ø)
das/metrics.go 9.91% <0.00%> (ø)
header/headertest/testing.go 71.92% <0.00%> (-6.98%) ⬇️
nodebuilder/module.go 85.71% <ø> (ø)
nodebuilder/p2p/bootstrap.go 6.66% <ø> (ø)
... and 36 more

... and 3 files with indirect coverage changes

Wondertan
Wondertan previously approved these changes Jun 2, 2023
state/core_access.go Show resolved Hide resolved
@Wondertan Wondertan enabled auto-merge (squash) June 5, 2023 09:53
@Wondertan Wondertan merged commit e5fcbe2 into celestiaorg:main Jun 5, 2023
Wondertan added a commit that referenced this pull request Jun 6, 2023
Co-authored-by: Hlib Kanunnikov <hlibwondertan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:state Related to fetching state and state execution kind:chore
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants