ci: configure prerelease-suffix #2990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Configure GoReleaser's prerelease-suffix: https://goreleaser.com/customization/git/#git If the prerelease-suffix is not configured, then GoReleaser will treat `v1.5.0-rc0` as more recent than `v1.5.0`. This is problematic because if the real release is cut after the release candidate, then GoReleaser won't attach pre-built binaries to the real release. This just happened on celestia-app v1.5.0 so ideally this saves ya'll some time when celestia-node starts publishing pre-built binaries. Motivating issue: celestiaorg/celestia-app#2897
rootulp
requested review from
renaynay,
Wondertan,
vgonkivs,
distractedm1nd,
walldiss and
ramin
as code owners
Wondertan
approved these changes
Dec 5, 2023
ramin
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configure GoReleaser's prerelease-suffix: https://goreleaser.com/customization/git/#git
If the prerelease-suffix is not configured, then GoReleaser will treat
v1.5.0-rc0as more recent thanv1.5.0. This is problematic because if the real release is cut after the release candidate, then GoReleaser won't attach pre-built binaries to the real release. This just happened on celestia-app v1.5.0 so ideally this saves ya'll some time when celestia-node starts publishing pre-built binaries.Motivating issue: celestiaorg/celestia-app#2897