Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Bridge node skips storing EDS if historic on sync #3261

Closed
wants to merge 12 commits into from
Closed

[WIP] Bridge node skips storing EDS if historic on sync #3261

wants to merge 12 commits into from

Conversation

renaynay
Copy link
Member

Based on #3188

@renaynay renaynay added area:storage kind:feat Attached to feature PRs labels Mar 19, 2024
@renaynay renaynay self-assigned this Mar 19, 2024
@renaynay renaynay marked this pull request as draft March 19, 2024 08:42
@renaynay renaynay mentioned this pull request Mar 28, 2024
Merged
@renaynay
Copy link
Member Author

closing in favour of #3283

@renaynay renaynay closed this Mar 28, 2024
renaynay added a commit that referenced this pull request Apr 10, 2024
@renaynay
feat(core): Bridge node short-circuits storing a historical EDS if pr…
26d411a 
…uning is enabled (#3283)

This PR implements short-circuiting storing EDSes in the case that they
are outside the sampling window in the case of a syncing bridge node if
`--experimental-pruning` is enabled.

Overrides #3261
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wondertan Wondertan Awaiting requested review from Wondertan Wondertan is a code owner

@vgonkivs vgonkivs Awaiting requested review from vgonkivs vgonkivs is a code owner

@distractedm1nd distractedm1nd Awaiting requested review from distractedm1nd distractedm1nd is a code owner

@walldiss walldiss Awaiting requested review from walldiss walldiss is a code owner

@ramin ramin Awaiting requested review from ramin

@cristaloleg cristaloleg Awaiting requested review from cristaloleg cristaloleg will be requested when the pull request is marked ready for review cristaloleg is a code owner

Assignees

@renaynay renaynay

Labels
area:storage kind:feat Attached to feature PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@renaynay