Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactoring(cmd/state): remove submit-tx from cli #3348

Merged
merged 2 commits into from
May 9, 2024

Conversation

vgonkivs
Copy link
Member

@vgonkivs vgonkivs commented Apr 30, 2024

Addresses a TODO in #3345

@vgonkivs vgonkivs added area:state Related to fetching state and state execution kind:refactor Attached to refactoring PRs labels Apr 30, 2024
@vgonkivs vgonkivs self-assigned this Apr 30, 2024
@renaynay renaynay added the kind:break! Attached to breaking PRs label Apr 30, 2024
Copy link
Collaborator

@distractedm1nd distractedm1nd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we have the doc PR lined up before we merge this?

@ramin
Copy link
Contributor

ramin commented Apr 30, 2024

image

Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please mark as break @vgonkivs

@renaynay
Copy link
Member

Oh i already did 😂

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.53%. Comparing base (2469e7a) to head (a9b3783).
Report is 60 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3348      +/-   ##
==========================================
- Coverage   44.83%   44.53%   -0.31%     
==========================================
  Files         265      272       +7     
  Lines       14620    15230     +610     
==========================================
+ Hits         6555     6782     +227     
- Misses       7313     7655     +342     
- Partials      752      793      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vgonkivs vgonkivs merged commit 34fa2ef into celestiaorg:main May 9, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:cli area:state Related to fetching state and state execution kind:break! Attached to breaking PRs kind:refactor Attached to refactoring PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants