-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cmd): fix namespace representation in cmd output #3537
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3537 +/- ##
==========================================
- Coverage 44.83% 44.54% -0.29%
==========================================
Files 265 273 +8
Lines 14620 15408 +788
==========================================
+ Hits 6555 6864 +309
- Misses 7313 7745 +432
- Partials 752 799 +47 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vgonkivs commitment is still printed in base64 when hex is printed for namespace and string for data, is this intentionally left?
Yes, non-base64 looks weird and it does not work with get methods |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Partly refs #3335
Current PR fixes namespace representation, so it will be consistent with the passed one. Blob cmds require hex-based namespaces only now.