fix(share/getters): set minTimeout #3591
Merged
+23
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgonkivs
added
area:shares
vgonkivs
requested review from
renaynay,
Wondertan,
distractedm1nd,
walldiss,
ramin and
cristaloleg
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3591 +/- ##
==========================================
+ Coverage 44.83% 45.62% +0.79%
==========================================
Files 265 280 +15
Lines 14620 15858 +1238
==========================================
+ Hits 6555 7236 +681
- Misses 7313 7794 +481
- Partials 752 828 +76 ☔ View full report in Codecov by Sentry. |
walldiss
reviewed
Jul 24, 2024
|
several integration tests failing @vgonkivs |
|
I'm not sure if my changes caused that. |
|
Looks like 1min timeout is just too much:
Maybe in tests we should keep 15sec or 30sec timeout, 2c. |
walldiss
approved these changes
Jul 30, 2024
Wondertan
approved these changes
Jul 30, 2024
cristaloleg
approved these changes
Aug 6, 2024
sebasti810
pushed a commit
to sebasti810/celestia-node
that referenced
this pull request
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set minTimeout in case the context hasn't contained it.