Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(store/cache): force close Accessor if not closed within timeout #3642

Merged
merged 5 commits into from
Aug 20, 2024
Merged

fix(store/cache): force close Accessor if not closed within timeout #3642

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f6ca94a
force close Accessor if not closed within timeout
walldiss Aug 8, 2024
553aad2
Update share/eds/cache/accessor_cache.go
walldiss Aug 14, 2024
3615feb
Merge branch 'main' into improve-refcloser-cache
walldiss Aug 14, 2024
4598bc9
remove finilisier
walldiss Aug 19, 2024
3a73508
Merge branch 'main' into improve-refcloser-cache
walldiss Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion share/eds/cache/accessor_cache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,10 +97,12 @@ func (s *accessorWithBlockstore) close() error {
done := s.done
s.Unlock()

// wait until all references are released or timeout is reached. If timeout is reached, log an
// error and close the accessor forcefully.
select {
case <-done:
case <-time.After(defaultCloseTimeout):
return fmt.Errorf("closing accessor, some readers didn't close the accessor within timeout,"+
log.Errorf("closing accessor, some readers didn't close the accessor within timeout,"+
" amount left: %v", s.refs.Load())
}
if err := s.shardAccessor.Close(); err != nil {
Expand Down
Loading