Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Decouple epoch_close from epoch_execute #1921

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Feat: Decouple epoch_close from epoch_execute #1921

wants to merge 5 commits into from

Conversation

mustermeiszer
Copy link
Collaborator

Description

See issue.

Fixes #1911

Changes and Descriptions

  • TBD

Checklist:

  • I have added Rust doc comments to structs, enums, traits and functions
  • I have made corresponding changes to the documentation
  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works

@mustermeiszer mustermeiszer force-pushed the feat/decouple-epoch-close-execute branch from 978d18d to f920e9b Compare July 19, 2024 07:43
lemunozm
lemunozm reviewed Jul 19, 2024
View reviewed changes
pallets/pool-system/src/pool_types.rs
MaxTranches: Get<u32>,
TrancheCurrency: Into<CurrencyId>,
{
pub struct PoolDetails<T: Config> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding T: Config to this type 🙏🏻

@mustermeiszer mustermeiszer added D7-essential Pull request essentially changes code. New Release needed. Audit would be nice. D5-breaks-api Pull request changes public api. Document changes publicly. D9-needsaudit Pull request touches sensitiv code parts and must be audited (externally). D8-migration Pull request touches storage and needs migration code. labels Jul 22, 2024
@wischli wischli added this to the DYF changes milestone Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemunozm lemunozm lemunozm left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
D5-breaks-api Pull request changes public api. Document changes publicly. D7-essential Pull request essentially changes code. New Release needed. Audit would be nice. D8-migration Pull request touches storage and needs migration code. D9-needsaudit Pull request touches sensitiv code parts and must be audited (externally).
Projects
None yet
Milestone
DYF changes
Development

Successfully merging this pull request may close these issues.

Feat: pallet-pool-system - Decouple Cash-Inflow from Epoch-Execution
3 participants
@mustermeiszer @lemunozm @wischli