Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support inspecting bigints (#1321) #1365

Closed
wants to merge 1 commit into from
Closed

fix: support inspecting bigints (#1321) #1365

wants to merge 1 commit into from

Conversation

vapier
Copy link
Contributor

@vapier vapier commented Oct 19, 2020

No description provided.

@vapier vapier requested a review from a team as a code owner October 19, 2020 02:42
@vapier
Copy link
Contributor Author

vapier commented Oct 19, 2020

running npm test seems to have regenerated chai.js with changes before mine. not sure if i should include them all here.

@keithamus
Copy link
Member

This looks like a great change, but we're working on integrating loupe into Chai 4.4.0 which will handle this behaviour.

I'm going to close this PR as it'll only be overwritten when we integrate loupe. We really value your contribution here though - and it would be amazing if you could add some tests to loupe to verify BigInt works! Would you be able to do that please?

Thanks!

@keithamus keithamus closed this Feb 4, 2021
@vapier vapier mentioned this pull request Mar 11, 2021
Closed
@vapier vapier deleted the master branch March 11, 2021 16:15
@vapier vapier mentioned this pull request Mar 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vapier @keithamus