External get func name #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like these need to be rebased? |
keithamus
reviewed
Oct 16, 2016
| constructorName = getFunctionName(errorLike); | ||
| if (constructorName === '') { | ||
| var newConstructorName = getFunctionName(new errorLike()); // eslint-disable-line new-cap | ||
| constructorName = newConstructorName ? newConstructorName : constructorName; |
There was a problem hiding this comment.
LGTM. My minor nitpick is this that could be constructorName = newConstructorName || constructorName; which I think would read better.
keithamus
approved these changes
Oct 16, 2016
|
@keithamus Yes! That looks better indeed! Thanks for the help. I have also rebased both PRs on master, they should be ready for a merge now. |
|
LGTM! |
|
LGTM |
|
@keithamus It says I don't have write access and therefore can't merge. Halp! |
|
Me to 🐼 |
|
Sorry, forgot to add the team to this repo. You should all be able to merge now 😄 |
|
Can anyone restart the build? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes a small refactor for this module to use the external
get-func-namemodule.Please notice that this has been made on top of #11.