feat(policies): document multi-kind policies #1327
Open
+22
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
migmartri
reviewed
Sep 16, 2024
| @@ -32,6 +32,28 @@ spec: | |||
| path: my-script.rego | |||
| ``` | |||
|
|
|||
| ### Supporting multiple material types | |||
There was a problem hiding this comment.
I'd review the example above to only use this new spec format, not the previous one, which is now deprecated correct? We should also rewrite the policies we have in place to that no?
migmartri
reviewed
Sep 16, 2024
| - kind: SARIF | ||
| path: cves-sarif.rego | ||
| ``` | ||
| In these cases, Chainloop will choose the right script to execute, but externally it would be seen as a single policy. |
There was a problem hiding this comment.
we should indicate that violations will be the sum of the violations in all the paths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to document multi-kind policies.