Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary stdlib dependency #421

Merged
merged 1 commit into from
Apr 28, 2023
Merged

Remove unnecessary stdlib dependency #421

merged 1 commit into from
Apr 28, 2023

Conversation

russellbanks
Copy link
Contributor

@russellbanks russellbanks commented Apr 26, 2023 •
edited
Loading

  • Since Kotlin 1.4.0, the stdlib dependency is longer required, and is added automatically according to the source set and Kotlin plugin version:
    • This means stdlib-jvm version 1.8.21 (the version of the Kotlin plugin) is automatically added anyway to the jvm source set.
  • Since Kotlin 1.8.0, stdlib-jdk8 has been merged into stdlib because JDK 6 and JDK 7 are no longer targets.
  • Version alignment is done automatically as above; the bom is only required if there are issues with this.

charleskorn
charleskorn approved these changes Apr 28, 2023
View reviewed changes
Copy link
Owner

@charleskorn charleskorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @russellbanks!

@charleskorn charleskorn merged commit d2d87e1 into charleskorn:main Apr 28, 2023
@russellbanks russellbanks deleted the remove-stdlib branch April 29, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charleskorn charleskorn charleskorn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@russellbanks @charleskorn