Enable collection renderer for all collection-like objects #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julik
approved these changes
Nov 3, 2023
|
I tried to integrate this into Cheddarsvc project, but multiple endpoints have failed with this switch. We probably need to support #array! method and combine that with existing CollectionRenderered code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've seen good performance gains from using
ActionView::CollectionRenderer, let's now use it for all collection like objects.On our Offers#list endpoint, we had a mean time of 1.48 seconds and once we enabled CollectionRenderer it went down 1.27 seconds mean. This brought us 15% improvement that we actually expected based on jbuilder experience.