Update to Python 3 #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove all lettuce code * Change file modes * Use io import * Inherit from object implicitly * Change bytes/string encodings * Change login test * Strip null characters from output * Make other 2 -> 3 changes * Gitignore .mypy_cache/
|
Hi. Could you change tox.ini and add python3 support (travis builds are failing)? And it'd be great to remove letucce from the docs. |
|
Hey. I changed tox to use Python 3 -- |
|
Hello! Anything else you'd like me to do for this PR? |
|
Will this be fixed soon or Should I patch it? |
|
Hi. What needs to be fixed? |
|
Glad you find it useful! I'll keep my fork for as long as #7 remains open. If this project is abandoned, feel free to work off my one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I ported this to Python 3. Unfortunately I had to remove all the lettuce code, although I don't think it's a huge loss. All the tests are passing and nothing seems to have broken.