Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transcription viewer opening before transcription completes #293

Conversation

chidiwilliams
Copy link
Owner

No description provided.

@chidiwilliams chidiwilliams changed the title 292-transcription-viewer-opens-with-empty-text-before-transcription-completes Fix transcription viewer opening before transcription completes Jan 3, 2023
@chidiwilliams chidiwilliams enabled auto-merge (squash) January 3, 2023 19:39
@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Merging #293 (18446a7) into main (d91a279) will increase coverage by 0.21%.
The diff coverage is 85.71%.

❗ Current head 18446a7 differs from pull request most recent head 8a18c7b. Consider uploading reports for the commit 8a18c7b to get more accurate results

@@            Coverage Diff             @@
##             main     #293      +/-   ##
==========================================
+ Coverage   77.32%   77.54%   +0.21%     
==========================================
  Files           8        8              
  Lines        1535     1541       +6     
==========================================
+ Hits         1187     1195       +8     
+ Misses        348      346       -2     
Flag Coverage Δ
Windows ?
macOS 77.54% <85.71%> (+0.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
buzz/gui.py 77.94% <85.71%> (+0.25%) ⬆️
buzz/transcriber.py 76.04% <0.00%> (+0.23%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@chidiwilliams chidiwilliams merged commit 40b0236 into main Jan 3, 2023
@chidiwilliams chidiwilliams deleted the 292-transcription-viewer-opens-with-empty-text-before-transcription-completes branch January 3, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transcription viewer opens with empty text before transcription completes
1 participant