Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Will remember previously used used huggingface model #736

Merged

Conversation

raivisdejus
Copy link
Collaborator

When using huggingface model custom model id is lost on subsequent uses, this makes it not too convenient to use.
This PR will improve usability

Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 81.34%. Comparing base (d483864) to head (cbf1293).
Report is 2 commits behind head on main.

❗ Current head cbf1293 differs from pull request most recent head dc9b44b. Consider uploading reports for the commit dc9b44b to get more accurate results

Files Patch % Lines
...dgets/transcriber/hugging_face_search_line_edit.py 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #736      +/-   ##
==========================================
- Coverage   81.97%   81.34%   -0.64%     
==========================================
  Files          83       81       -2     
  Lines        3840     3586     -254     
==========================================
- Hits         3148     2917     -231     
+ Misses        692      669      -23     
Flag Coverage Δ
Linux ?
Windows 81.34% <77.77%> (-0.02%) ⬇️
macOS ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chidiwilliams chidiwilliams enabled auto-merge (squash) May 14, 2024 22:59
@chidiwilliams chidiwilliams merged commit ca49b8e into chidiwilliams:main May 14, 2024
8 of 10 checks passed
@raivisdejus raivisdejus deleted the remember-previously-used-model-id branch May 15, 2024 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants