Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed race condition with calculation for left and right coordinates … #127

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

falkobuttler
Copy link

…of map view to calculate length

This caused the cell size sometimes to be 0 due to a race condition when converting coordinates from the map view to its super view. When that happened, all annotations become invisible. This constantly happens when rotating, especially in flyover mode.
Instead we are now calculating it against its own view, which always returns consistent and valid results.

…of map view to calculate length

This caused the cell size sometimes to be 0 due to a race condition when converting coordinates from the map view to its super view. When that happened, all annotations become invisible. This constantly happens when rotating, especially in flyover mode.
Instead we are now calculating it against its own view, which always returns consistent and valid results.
@choefele
Copy link
Owner

Thanks for your PR. Could you please send me some step-by-step instructions how to reproduce the problem your are fixing with the sample app? I'd like to verify the solution of this issue. I'm not really sure how there would be a race condition around the super view of a view.

Also, [mapView convertPoint:CGPointZero toCoordinateFromView:mapView] in your code effectively makes this call redundant. My understanding is that the super view is required to convert the point into the correct coordinate system.

@choefele
Copy link
Owner

Also: your code causes the unit tests to fail because you changed the method parameters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants