-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Method for both removing and adding annotations #68
base: master
Are you sure you want to change the base?
Conversation
Sorry for the late response and thanks for your pull request. I was thinking to support this use case in a similar way to I think this would make for a cleaner API. What do you think? |
Yes, it will make more universal API, but for now I think it is overengineering. Let's accept my pull request and if someone will need begin/end updates then convert api to it. |
Hi. Will you accept this PR? |
What's the status here? |
I'm not really sure if the proposed API is a good idea. I was thinking about a beginUpdates/endUpdates style API. @mikrobi In what context would this feature be useful to you? |
Actually I agree with you. After taking a deeper look I'm just working with the currently available methods ;) |
Hello, |
A beginUpdates/endUpdates style API would be great. But here's how I solved this for my NSFetchedResultsController case using the current code base: Instead of performing add/removeAnnotations for each update, just collection those annotations in a couple of arrays and them batch process them in controllerDidChangeContent.
This code snippet is not a direct copy/paste from my code, so it may not be 100% syntactically correct. |
@markkrenek Thanks for your example |
Method for both removing and adding annotations in one go. Useful when integrating with CoreData.