Skip to content

Commit

Permalink
deps: Upgrade jetifier to 2.0.0, the latest.
Browse files Browse the repository at this point in the history
Here's the description from the changelog [1]:

> Exact same as 1.6.7 was, just as a breaking change semver number
>
> docs(CHANGELOG): prepare release 2.0.0 f483026
> BREAKING: note that jetifier is deprecated, warn on translations
>   699094b

It looks like in 1.6.7 the tool started giving an important
deprecation warning about itself. But then the warning was taken out
in 1.6.8 because it was deemed to be a breaking change that deserved
a new major version. 2.0.0 was that new major version.

Right now, for us, the warning looks like this:

```
Jetifier is deprecated. Future versions of react-native CLI may not
  run it by default.
Jetifier found 1372 file(s) to forward-jetify. Using 12 workers...
Jetifier: propose an AndroidX conversion PR to this repository:
  node_modules/react-native-photo-view/android/src/main/java/com/reactnative/photoview/ImageEvent.java
Jetifier: propose an AndroidX conversion PR to this repository:
  node_modules/react-native-photo-view/android/src/main/java/com/reactnative/photoview/PhotoView.java
```

I'm not sure if we have to wait for 1372 files to move to AndroidX
before we can stop using this tool...but at least we have an issue
(zulip#4217) for using something more maintained than
react-native-photo-view, which should take care of the two mentions
of that library.

Anyway, take this upgrade, in the spirit of not ignoring warnings
that we should act on. And it's just four lines of output.

Also I guess because we'll want `yarn upgrade` to automatically give
us any new, non-breaking changes in the tool.

[1] https://github.com/mikehardy/jetifier/releases
  • Loading branch information
chrisbobbe committed Aug 10, 2021
1 parent e61ab0d commit e4f6835
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@
"jest-environment-jsdom-global": "^2.0.4",
"jest-expo": "^40.0.1",
"jest-extended": "^0.11.5",
"jetifier": "^1.6.5",
"jetifier": "^2.0.0",
"lolex": "^5.1.1",
"metro-react-native-babel-preset": "^0.64.0",
"prettier": "^1.18.2",
Expand Down
7 changes: 6 additions & 1 deletion yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -7544,11 +7544,16 @@ jest@^25.2.0, jest@^26.4.1, jest@^26.6.3:
import-local "^3.0.2"
jest-cli "^26.6.3"

jetifier@^1.6.2, jetifier@^1.6.5:
jetifier@^1.6.2:
version "1.6.8"
resolved "https://registry.yarnpkg.com/jetifier/-/jetifier-1.6.8.tgz#e88068697875cbda98c32472902c4d3756247798"
integrity sha512-3Zi16h6L5tXDRQJTb221cnRoVG9/9OvreLdLU2/ZjRv/GILL+2Cemt0IKvkowwkDpvouAU1DQPOJ7qaiHeIdrw==

jetifier@^2.0.0:
version "2.0.0"
resolved "https://registry.yarnpkg.com/jetifier/-/jetifier-2.0.0.tgz#699391367ca1fe7bc4da5f8bf691eb117758e4cb"
integrity sha512-J4Au9KuT74te+PCCCHKgAjyLlEa+2VyIAEPNCdE5aNkAJ6FAJcAqcdzEkSnzNksIa9NkGmC4tPiClk2e7tCJuQ==

jimp@0.12.1:
version "0.12.1"
resolved "https://registry.yarnpkg.com/jimp/-/jimp-0.12.1.tgz#3e58fdd16ebb2b8f00a09be3dd5c54f79ffae04a"
Expand Down

0 comments on commit e4f6835

Please sign in to comment.