Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DCO and commit-message.md #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add DCO and commit-message.md #1

wants to merge 3 commits into from

Conversation

chriscool
Copy link
Owner

No description provided.

@GitCop
Copy link

GitCop commented Jun 6, 2015

There were the following issues with your Pull Request

  • Commit: 715d8b6
    • Invalid signoff. Commit message must end with Licence: MIT
      Signed-off-by: .* <.*>

Guidelines are available at https://github.com/chriscool/go-ipfs


This message was auto-generated by https://gitcop.com

@GitCop
Copy link

GitCop commented Jun 6, 2015

There were the following issues with your Pull Request

  • Commit: bd9b513
    • Invalid signoff. Commit message must end with Licence: MIT
      Signed-off-by: .* <.*>

Guidelines are available at https://github.com/chriscool/go-ipfs


This message was auto-generated by https://gitcop.com

License: MIT
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
@GitCop
Copy link

GitCop commented Jun 6, 2015

There were the following issues with your Pull Request

  • Commit: c995f70
    • Invalid signoff. Commit message must end with Licence: MIT
      Signed-off-by: .* <.*>

Guidelines are available at https://github.com/chriscool/go-ipfs/commit-message.md


This message was auto-generated by https://gitcop.com

Licence: MIT
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
@GitCop
Copy link

GitCop commented Jun 6, 2015

There were the following issues with your Pull Request

  • Commit: c995f70
    • Invalid signoff. Commit message must end with Licence: MIT
      Signed-off-by: .* <.*>
  • Commit: 695e29c
    • Invalid signoff. Commit message must end with Licence: MIT
      Signed-off-by: .* <.*>

Guidelines are available at https://github.com/chriscool/go-ipfs/commit-message.md


This message was auto-generated by https://gitcop.com

properly written. The rules are the following:

* The first line of a commit message, called the subject line should
not be more than 80 characters long.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i thought it was supposed to be:

  • first line max 50 chars
  • all other lines, soft max of 72 chars (links break this, for example)

what does the git project use?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think GitHub warns at 50 characters for the subject but accepts more than that.
In fact I think it accepts anything when you push.

The guidelines for the Git project are 80 characters for everything I think (code, comments, commit messages).

@jbenet
Copy link

jbenet commented Jun 6, 2015

maybe let's put all the guidelines and commit hook stuff over in https://github.com/ipfs/community ? under a directory like dev/tools/commits or something?

cause we'll need to enable this for a lot of repos.

@chriscool
Copy link
Owner Author

Ok I will put everything in: https://github.com/ipfs/community

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants