-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DCO and commit-message.md #1
base: master
Are you sure you want to change the base?
Conversation
There were the following issues with your Pull Request
Guidelines are available at https://github.com/chriscool/go-ipfs This message was auto-generated by https://gitcop.com |
715d8b6
to
bd9b513
Compare
There were the following issues with your Pull Request
Guidelines are available at https://github.com/chriscool/go-ipfs This message was auto-generated by https://gitcop.com |
bd9b513
to
95ca4d0
Compare
a12ed19
to
f9146fb
Compare
License: MIT Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
f9146fb
to
8fc68d8
Compare
There were the following issues with your Pull Request
Guidelines are available at https://github.com/chriscool/go-ipfs/commit-message.md This message was auto-generated by https://gitcop.com |
Licence: MIT Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
8fc68d8
to
093916f
Compare
There were the following issues with your Pull Request
Guidelines are available at https://github.com/chriscool/go-ipfs/commit-message.md This message was auto-generated by https://gitcop.com |
properly written. The rules are the following: | ||
|
||
* The first line of a commit message, called the subject line should | ||
not be more than 80 characters long. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i thought it was supposed to be:
- first line max 50 chars
- all other lines, soft max of 72 chars (links break this, for example)
what does the git project use?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I think GitHub warns at 50 characters for the subject but accepts more than that.
In fact I think it accepts anything when you push.
The guidelines for the Git project are 80 characters for everything I think (code, comments, commit messages).
maybe let's put all the guidelines and commit hook stuff over in https://github.com/ipfs/community ? under a directory like cause we'll need to enable this for a lot of repos. |
Ok I will put everything in: https://github.com/ipfs/community |
No description provided.