Improved state layout checks and add minor clarifications #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerosnacks
commented
Jun 30, 2023
Comment on lines
+251
to
+260
| vm.record(); | ||
| dispatcher.getToken(tokenA_, address(dispatcher)); | ||
| (reads, ) = vm.accesses(address(dispatcher)); | ||
| assertEq((reads[0]), keccak256(abi.encode(tokenA_, uint256(IMPLEMENTATION_STORAGE_SLOT) + 5))); | ||
|
|
||
| vm.record(); | ||
| dispatcher.getToken(tokenB_, address(dispatcher)); | ||
| (reads, ) = vm.accesses(address(dispatcher)); | ||
| assertEq((reads[0]), keccak256(abi.encode(tokenB_, uint256(IMPLEMENTATION_STORAGE_SLOT) + 5))); | ||
| } |
There was a problem hiding this comment.
This currently doesn't include a full 1:1 check for the struct, I don't think its worth the time or effort.
The base case of a struct in storage is handled above in ReflexState.relations
pedrommaiaa
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new tests we don't need to rely on a storage report generation feature because we explicitly test the locations of each storage slot with its expected behavior.