Skip to content
This repository has been archived by the owner on Jan 6, 2022. It is now read-only.

Fix typo so lyrics view won't bug out #252

Merged
merged 2 commits into from
Oct 14, 2021
Merged

Fix typo so lyrics view won't bug out #252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e63cbf4
Fix lyrics view issue
vapormusic Oct 14, 2021
29a5235
Merge branch 'Apple-Music-Electron:master' into ui-refresh
vapormusic Oct 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion resources/js/custom.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ try {
document.querySelector('#lyricsButton').style.fill = 'var(--playerPlatterButtonIconFill)';
document.querySelector('#lyricsButton').style.boxShadow = '0 1px 1px rgb(0 0 0 / 10%)';
document.querySelector('#lyricsButton').style.background = 'var(--playerPlatterButtonBGFill)';
if (document.getElementById('lyricer').childNodes[0].childNodes.length != null || document.getElementById('lyricer').childNodes[0].childNodes.length <= 1){
if (document.getElementById('lyricer').childNodes[0].childNodes.length == null || document.getElementById('lyricer').childNodes[0].childNodes.length <= 1){
_lyrics.GetLyrics(1,false);}
}

Expand Down
4 changes: 3 additions & 1 deletion resources/js/lyrics.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,9 @@
for (let i = 0; i < self.totalLines; i++) {
const li = document.getElementById(self.lineidPrefix + i);
if (i >= startShow && i <= endShow) {
li.style.display = "block";
try{
li.style.display = "block";}
catch(e){}
} else {
li.style.display = "block";
}
Expand Down