Update to Handsontable 13.0.1 to enable batch() quick render. #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.alter('insert_row'...) -> .alter('insert_row_below' ...
hiddenColsPlugin.showColumns(hiddenColsPlugin.hiddenColumns);
-> const hidden = hiddenColsPlugin.getHiddenColumns();
etc.
Remaining problem is with flatpickr datepicker?
Change on Handsontable.dom method name
Includes new DataHarmonizer .fields property = getFields() call.
Changing to merge provenanceChanges and cellChanges array for rendering efficiency.
ddooley
changed the title
I'll close the PR since it looks to me like a straightforward upgrade, but could you explain this issue? |
|
Hi Kenneth - issue is explained in #408 . It turns out solution may not have required a Handsontable upgrade but I did it anyways (and Patrick was ok with upgrade). |
|
Also it does introduce a new property for a loaded schema template: "this.fields = this.getFields(); " . This means code can be a bit more efficient elsewhere by replacing .getFields() calls with this.fields references. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2ndary code changes required for handsontable upgrade below:
Remaining problem is with flatpickr datepicker?