Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use existing todos conventions for min/max constraints #426

Merged
merged 6 commits into from
Dec 19, 2023

Conversation

pkalita-lbl
Copy link
Collaborator

@pkalita-lbl pkalita-lbl commented Dec 14, 2023

These changes update the Validator class to be consistent with existing conventions around storing minimum and maximum date values in todos with the >= and <= prefixes. It also allows enables the use of the convention of >={other slot name} or <={other slot name} in todos to indicate that the min/max value for one slot is dependent on the value of another slot.

I added cases to the unit test and did some basic interactive testing with the covid template. I think it's working as expected without any changes to the existing schema. But please give it a good test and let me know if you find any existing schemas that aren't being interpreted correctly!

@ddooley ddooley merged commit c076baf into master Dec 19, 2023
1 check passed
@ddooley ddooley deleted the fix-min-max-from-todos branch December 19, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants