Skip to content

Commit

Permalink
connectivity: Add "Link not found" in the exception list
Browse files Browse the repository at this point in the history
This "Link not found" message shows up frequently, causing the
connectivity test to fail. Add the message to the error / warning log
exceptions until #1894 is resolved.

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
  • Loading branch information
michi-covalent committed Feb 27, 2024
1 parent 4d44a7e commit 9f5dcc2
Showing 1 changed file with 11 additions and 1 deletion.
12 changes: 11 additions & 1 deletion connectivity/tests/errors.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,18 @@ import (
func NoErrorsInLogs(ciliumVersion semver.Version) check.Scenario {
// Exceptions for level=error should only be added as a last resort, if the
// error cannot be fixed in Cilium or in the test.
errorLogExceptions := []string{"Error in delegate stream, restarting", failedToListCRDs, removeInexistentID}
errorLogExceptions := []string{
"Error in delegate stream, restarting",
failedToListCRDs,
removeInexistentID,
linkNotFound,
}
if ciliumVersion.LT(semver.MustParse("1.14.0")) {
errorLogExceptions = append(errorLogExceptions, previouslyUsedCIDR)
}
warningLogExceptions := []string{
linkNotFound,
}
// The list is adopted from cilium/cilium/test/helper/utils.go
var errorMsgsWithExceptions = map[string][]string{
panicMessage: nil,
Expand All @@ -53,6 +61,7 @@ func NoErrorsInLogs(ciliumVersion semver.Version) check.Scenario {
emptyIPNodeIDAlloc: nil,
"DATA RACE": nil,
"level=error": errorLogExceptions,
"level=warning": warningLogExceptions,
}
return &noErrorsInLogs{errorMsgsWithExceptions}
}
Expand Down Expand Up @@ -245,4 +254,5 @@ const (
emptyIPNodeIDAlloc = "Attempt to allocate a node ID for an empty node IP address"
failedToListCRDs = "the server could not find the requested resource" // cf. https://github.com/cilium/cilium/issues/16425
previouslyUsedCIDR = "Unable to find identity of previously used CIDR" // from https://github.com/cilium/cilium/issues/26881
linkNotFound = "Link not found" // https://github.com/cilium/cilium-cli/issues/1894
)

0 comments on commit 9f5dcc2

Please sign in to comment.