-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Cilium CLI work with Cilium installed through helm with a non-default name #2274
Comments
hey @giorio94, I would like to work on this issue. Could you please guide me on this? |
Sure, the idea is to make the helm release name configurable through a flag, similarly to the namespace case. I'd suggest starting with introducing the new flag (which defaults to the current value), and then look for all the usages of Feel free to reach out if you have more questions. |
@prashantrewar Do you have news about this issue? |
This update introduces a new parameter across several functions and actions to allow the user to specify a Helm release name for the Cilium installation. This enables multiple Cilium installations within the same cluster, or referencing installations installed via Helm directly. The default Helm release name remains "cilium" when no custom release name is provided. Fixes: cilium#2274 Signed-off-by: Matthew Hembree <47449406+matthewhembree@users.noreply.github.com>
@prashantrewar I wasn't sure if you were actively working on this or if you were busy with other things. I checked for a existing fork. Apologies for being impatient, but I was interested in using the fix. |
This update introduces a new parameter across several functions and actions to allow the user to specify a Helm release name for the Cilium installation. This enables referencing installations installed via Helm directly. The default Helm release name remains "cilium" when no custom release name is provided. Fixes: cilium#2274 Signed-off-by: Matthew Hembree <47449406+matthewhembree@users.noreply.github.com>
This update introduces a new parameter across several functions and actions to allow the user to specify a Helm release name for the Cilium installation. This enables referencing installations installed via Helm directly. The default Helm release name remains "cilium" when no custom release name is provided. Fixes: cilium#2274 Signed-off-by: Matthew Hembree <47449406+matthewhembree@users.noreply.github.com>
This is to allow `cilium hubble disable --helm-release-name foo` as missing from a previous/complimentary commit. Fixes: cilium#2274 Signed-off-by: Matthew Hembree <47449406+matthewhembree@users.noreply.github.com>
…ninstall. This is to allow `cilium uninstall --helm-release-name foo` to correctly uninstall Hubble before uninstalling the core Cilium. This includes a fix to specify the namespace. Fixes: cilium#2274 Signed-off-by: Matthew Hembree <47449406+matthewhembree@users.noreply.github.com>
This update introduces a new parameter across several functions and actions to allow the user to specify a Helm release name for the Cilium installation. This enables referencing installations installed via Helm directly. The default Helm release name remains "cilium" when no custom release name is provided. Fixes: cilium#2274 Signed-off-by: Matthew Hembree <47449406+matthewhembree@users.noreply.github.com>
This is to allow `cilium hubble disable --helm-release-name foo` as missing from a previous/complimentary commit. Fixes: cilium#2274 Signed-off-by: Matthew Hembree <47449406+matthewhembree@users.noreply.github.com>
…ninstall. This is to allow `cilium uninstall --helm-release-name foo` to correctly uninstall Hubble before uninstalling the core Cilium. This includes a fix to specify the namespace. Fixes: cilium#2274 Signed-off-by: Matthew Hembree <47449406+matthewhembree@users.noreply.github.com>
This update introduces a new parameter across several functions and actions to allow the user to specify a Helm release name for the Cilium installation. This enables referencing installations installed via Helm directly. The default Helm release name remains "cilium" when no custom release name is provided. Fixes: cilium#2274 Signed-off-by: Matthew Hembree <47449406+matthewhembree@users.noreply.github.com>
This is to allow `cilium hubble disable --helm-release-name foo` as missing from a previous/complimentary commit. Fixes: cilium#2274 Signed-off-by: Matthew Hembree <47449406+matthewhembree@users.noreply.github.com>
…ninstall. This is to allow `cilium uninstall --helm-release-name foo` to correctly uninstall Hubble before uninstalling the core Cilium. This includes a fix to specify the namespace. Fixes: cilium#2274 Signed-off-by: Matthew Hembree <47449406+matthewhembree@users.noreply.github.com>
This update introduces a new parameter across several functions and actions to allow the user to specify a Helm release name for the Cilium installation. This enables referencing installations installed via Helm directly. The default Helm release name remains "cilium" when no custom release name is provided. Fixes: cilium#2274 Signed-off-by: Matthew Hembree <47449406+matthewhembree@users.noreply.github.com>
This is to allow `cilium hubble disable --helm-release-name foo` as missing from a previous/complimentary commit. Fixes: cilium#2274 Signed-off-by: Matthew Hembree <47449406+matthewhembree@users.noreply.github.com>
…ninstall. This is to allow `cilium uninstall --helm-release-name foo` to correctly uninstall Hubble before uninstalling the core Cilium. This includes a fix to specify the namespace. Fixes: cilium#2274 Signed-off-by: Matthew Hembree <47449406+matthewhembree@users.noreply.github.com>
This update introduces a new parameter across several functions and actions to allow the user to specify a Helm release name for the Cilium installation. This enables referencing installations installed via Helm directly. The default Helm release name remains "cilium" when no custom release name is provided. Fixes: #2274 Signed-off-by: Matthew Hembree <47449406+matthewhembree@users.noreply.github.com>
This is to allow `cilium hubble disable --helm-release-name foo` as missing from a previous/complimentary commit. Fixes: #2274 Signed-off-by: Matthew Hembree <47449406+matthewhembree@users.noreply.github.com>
…ninstall. This is to allow `cilium uninstall --helm-release-name foo` to correctly uninstall Hubble before uninstalling the core Cilium. This includes a fix to specify the namespace. Fixes: #2274 Signed-off-by: Matthew Hembree <47449406+matthewhembree@users.noreply.github.com>
Quite a few Cilium CLI commands fail with a
release: not found
error if Cilium got installed through helm with a non-default name.For instance:
This happens because we hardcode the default release name (for instance here). Instead, we should make it user-configurable, similarly to the namespace where Cilium is installed.
The text was updated successfully, but these errors were encountered: