Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build release binaries on pull requests #2136

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Build release binaries on pull requests #2136

merged 2 commits into from
Dec 1, 2023

Conversation

michi-covalent
Copy link
Contributor

2 commits:

  • build release artifacts on pull requests to make sure all the binaries build successfully.
  • drop 32-bit binaries from release artifacts. it's time to move on.

@michi-covalent michi-covalent requested review from a team as code owners November 29, 2023 22:04
@michi-covalent michi-covalent mentioned this pull request Nov 29, 2023
Open
@michi-covalent
Build release binaries on pull requests
a695271 
Make sure all the release binaries build successfully.

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
@michi-covalent
release: Only build 64-bit binaries
dc9f2e2 
Let's drop 32-bit binaries from release artifacts.

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
mhofstetter
mhofstetter approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@mhofstetter mhofstetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - thanks for considering my input!

@tklauser tklauser merged commit 610fd07 into main Dec 1, 2023
20 checks passed
@tklauser tklauser deleted the pr/michi/lets-go-again branch December 1, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tklauser tklauser tklauser approved these changes

@joestringer joestringer joestringer approved these changes

@mhofstetter mhofstetter mhofstetter approved these changes

@nbusseneau nbusseneau Awaiting requested review from nbusseneau nbusseneau is a code owner automatically assigned from cilium/github-sec

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michi-covalent @tklauser @joestringer @mhofstetter