Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve error messages for Helm commands #2597

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

cnvergence
Copy link

@cnvergence cnvergence commented Jun 13, 2024

Fixes: #1907

Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
@cnvergence cnvergence marked this pull request as ready for review June 13, 2024 14:34
@cnvergence cnvergence requested a review from a team as a code owner June 13, 2024 14:34
@cnvergence cnvergence requested a review from derailed June 13, 2024 14:34
@cnvergence
Copy link
Author

/retest

Copy link
Contributor

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cnvergence Thank you for these updates!

cli/clustermesh.go Outdated Show resolved Hide resolved
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
@cnvergence
Copy link
Author

@derailed PTAL again :)

Copy link
Contributor

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cnvergence Thank you for the updates!

@derailed
Copy link
Contributor

derailed commented Jul 9, 2024

/test

1 similar comment
@cnvergence
Copy link
Author

/test

@cnvergence
Copy link
Author

hi @derailed, shall I fix something in this PR?

@cnvergence
Copy link
Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve error messages for "release not found"
2 participants