feat: Add support for impersonation --as and --as-group flags #2696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cameron McAvoy <cmcavoy@indeed.com>
|
/test |
nathanjsweet
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use impersonation as cluster admins to elevate access to customer secrets and certain resources, and kubectl supports this with the --as or --as-group flags. Currently to use the cilium cli tool, we have to hand edit our kubeconfig to add
as: <user>for our user, and then remember to remove it afterwords. Supporting impersonation directly in the Cilium cli tooling would make it much safer for us and align cilium with other kubectl flags.