cmd: Remove deprecated --config-file flag #1498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lambdanis
added
area/userspace
|
The podinfo integration tests failed on three attempts with "Condition never satisfied": but locally they pass, and this PR shouldn't affect them. I'll retry once again, maybe we need to increase the timeout. UPDATE: ok, I just had to rebase with main and it's all green now. |
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
lambdanis
force-pushed
the
pr/lambdanis/remove-deprecated
branch
4 times, most recently
from
68a204a
to
4d1d16c
Compare
Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
lambdanis
force-pushed
the
pr/lambdanis/remove-deprecated
branch
from
4d1d16c
to
239f57a
Compare
|
I'm sort of attached to that flag but ok away it goes. |
mtardy
reviewed
Sep 22, 2023
| log.Warnf("Flag --%s has been deprecated, please use --%s instead", keyConfigFile, keyTracingPolicy) | ||
| option.Config.TracingPolicy = viper.GetString(keyConfigFile) | ||
| } | ||
| // if both --config-file and --tracing-policy are set, the latter takes priority | ||
| if viper.IsSet(keyTracingPolicy) { |
There was a problem hiding this comment.
We could have removed this (now useless) check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the code comments the
--config-fileflag should have been removed in the v0.11 release, but it hasn't been. Let's remove it before the next release.Ref #651