-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix property naming #2006
Conversation
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, sure thanks for the fix! :)
It looks like your commit is not signed-off, to improve tracking of who did what, the Tetragon project uses a "sign-off" procedure which you can learn more about in the Cilium project documentation.
Concretely it consists of adding your real name and an email address to your git config and using git commit -s
to write your commit message. You can use git commit --amend -s
to add the signature to existing commits.
See more details on how to comply with the "sign-off" procedure
To add your name and email to your git config:
git config user.email "mail@example.com"
git config user.name "firstname lastname"
Note: add the --global
flag after config
to configure this by default for repositories on your host.
Then you can use for new commits:
git commit -s
Or for existing commits on which you want to add the signed-off-by
statement:
git commit --amend -s
For more information, see this extract from git-commit(1)
man page regarding the -s
flag:
-s, --signoff, --no-signoff
Add a Signed-off-by trailer by the committer at the end of the commit log
message. The meaning of a signoff depends on the project to which you're
committing. For example, it may certify that the committer has the rights to
submit the work under the project's license or agrees to some contributor
representation, such as a Developer Certificate of Origin. (See
http://developercertificate.org for the one used by the Linux kernel and Git
projects.) Consult the documentation or leadership of the project to which
you're contributing to understand how the signoffs are used in that project.
The --no-signoff option can be used to countermand an earlier --signoff
option on the command line.
Signed-off-by: Rico Pahlisch <pahli88@googlemail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This PR fixes wrong naming for
followForks
.