tetragon: Limit max entries of cgroup_rate_map when it's not used #2555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olsajiri
added
the
release-note/minor
olsajiri
force-pushed
the
pr/olsajiri/cgroup_rate_fix
branch
from
bfdc038
to
7c5848d
Compare
mtardy
approved these changes
Jun 14, 2024
pkg/sensors/base/base.go
Outdated
| @@ -15,6 +15,10 @@ import ( | |||
| "github.com/cilium/tetragon/pkg/sensors/program" | |||
| ) | |||
|
|
|||
| const ( | |||
| hasMapMaxEntries = 32768 // this value could be fine tuned | |||
There was a problem hiding this comment.
nit: maybe the name could be related to the cgroup map?
bpf/process/bpf_rate.h
Outdated
| @@ -27,7 +27,7 @@ struct cgroup_rate_options { | |||
|
|
|||
| struct { | |||
| __uint(type, BPF_MAP_TYPE_PERCPU_HASH); | |||
| __uint(max_entries, 32768); | |||
| __uint(max_entries, 1); | |||
There was a problem hiding this comment.
nit: maybe adding a little comment that this can be resized at sensor loading time
It's not needed when the feature is disabled. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
olsajiri
force-pushed
the
pr/olsajiri/cgroup_rate_fix
branch
from
7c5848d
to
741ffdb
Compare
mtardy
added
needs-backport/1.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not needed when the feature is disabled.