Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trex.common.services.trex_service_IPv6ND broken for some IPv6 VRRP implementations #1144

Open
haklat43 opened this issue Aug 19, 2024 · 0 comments

Comments

@haklat43
Copy link

The TRex is looking in the wrong packet field when trying to interpret a NA received from GW. For at least some VRRP implementations the IPv6 src address in an NA is not same as the actual VRRP IPv6 address. IPv6 VRRP address in NA response should probably be filter on

scapy_pkt[ICMPv6ND_NA].tgt and not scapy_pkt[IPv6].src

Suggest following change in
automation/trex_control_plane/interactive/trex/common/services/trex_service_IPv6ND.py

In lookup function:
from:

    if ICMPv6ND_NA in scapy_pkt:
        return self.services.get((scapy_pkt[IPv6].dst, scapy_pkt[IPv6].src, tuple(vlans)), [] ) 

to:

    if ICMPv6ND_NA in scapy_pkt:
        return self.services.get((scapy_pkt[IPv6].dst, scapy_pkt[ICMPv6ND_NA].tgt, tuple(vlans)), [] )
haklat43 added a commit to haklat43/trex-core that referenced this issue Aug 22, 2024
Signed-off-by: Hakan Latth <haklat43@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant