Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fish/complete: Generate helper functions to check for subcommands #5568

Merged
merged 9 commits into from
Jul 11, 2024
Merged

fish/complete: Generate helper functions to check for subcommands #5568

merged 9 commits into from
Jul 11, 2024

Commits on Jul 6, 2024

  1. feat(fish): Support nested subcommand completion

    @tesuji
    tesuji committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    a6ac45f View commit details
    Browse the repository at this point in the history

  2. fix(fish): Don't handle level 3 nested subcommand 

    Nested subcommand more than 3 levels is not practical in public.
Take rustup for example, `rustup toolchain install <version>`,
there is only 3 levels of nested subcommands. But there is also
the case of `rustup help toolchain install`, or `rustup toolchain help install`.
    @tesuji
    tesuji committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    2167fee View commit details
    Browse the repository at this point in the history

  3. chore: Use get_action to filter out help/version flags

    @tesuji
    tesuji committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    6c706d5 View commit details
    Browse the repository at this point in the history

  4. fix: Fix conditions to generate helpers 

    Both should be met.
    @tesuji
    tesuji committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    e276fc4 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2024

  1. fix: Check for real optional arguments

    @tesuji
    tesuji committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    1dd1056 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. chore: Explain why -lt 3 levels of subcommands

    @tesuji
    tesuji committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    eba26a9 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. doc: Explain why we fallback to the old behavior

    @tesuji
    tesuji committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    0462be6 View commit details
    Browse the repository at this point in the history

  2. style: Prefer matching with enum name

    @tesuji
    tesuji committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    76b9c46 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. fix: Only generate stubs if has subcommands

    @tesuji
    tesuji committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    6243d65 View commit details
    Browse the repository at this point in the history