Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: localnet for Apple Silicon #118

Merged
merged 7 commits into from
Feb 14, 2023
Merged

build: localnet for Apple Silicon #118

merged 7 commits into from
Feb 14, 2023

Conversation

inon-man
Copy link
Collaborator

@inon-man inon-man commented Feb 13, 2023 •
edited
Loading

Summary of changes

make localnet-start script allows you to start up 4 nodes locally using Docker. This PR addresses an issue with that script not working on Apple Silcon machines.

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated API documentation (client/lcd/swagger-ui/swagger.yaml)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@inon-man inon-man added the out of scope work that is unapproved by the community, but still essential for the L1 team label Feb 13, 2023
@inon-man inon-man changed the title build: localnet for Apple Silicon and reduce time for sim tests build: localnet for Apple Silicon Feb 13, 2023
@inon-man inon-man self-assigned this Feb 13, 2023
@inon-man inon-man marked this pull request as ready for review February 13, 2023 19:19
@inon-man inon-man added this to the v2.0.0 milestone Feb 13, 2023
ZaradarBH
ZaradarBH approved these changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@ZaradarBH ZaradarBH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

nghuyenthevinh2000
nghuyenthevinh2000 reviewed Feb 14, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@inon-man inon-man merged commit 56eda11 into main Feb 14, 2023
@inon-man inon-man deleted the fix-localnet branch February 14, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nghuyenthevinh2000 nghuyenthevinh2000 nghuyenthevinh2000 approved these changes

@ZaradarBH ZaradarBH ZaradarBH approved these changes

@fragwuerdig fragwuerdig Awaiting requested review from fragwuerdig

Assignees

@inon-man inon-man

Labels
out of scope work that is unapproved by the community, but still essential for the L1 team
Projects
None yet
Milestone
Core - v1.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@inon-man @nghuyenthevinh2000 @ZaradarBH