Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: panic at columbus genesis #128

Merged
merged 3 commits into from
Feb 17, 2023
Merged

feat: panic at columbus genesis #128

merged 3 commits into from
Feb 17, 2023

Conversation

inon-man
Copy link
Collaborator

@inon-man inon-man commented Feb 17, 2023

Summary of changes

This is a complementary feature for operators who are trying to use version > v1.0 for importing the genesis of Columbus mainnet.

For example, genesis importing is essential if someone wants to use PebbleDB implementation, in which case a new DB must be built based on v1.0.x

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated API documentation (client/lcd/swagger-ui/swagger.yaml)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@inon-man inon-man marked this pull request as ready for review February 17, 2023 07:02
Copy link
Contributor

@ZaradarBH ZaradarBH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Copy link
Collaborator

@edk208 edk208 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we specifically say v1.0.5-full-archive should be used? I think that is the only one completely compatible

@ZaradarBH ZaradarBH added enhancement New feature or request Value-Add labels Feb 17, 2023
@ZaradarBH ZaradarBH added this to the Core - v1.1.0 milestone Feb 17, 2023
@ZaradarBH ZaradarBH merged commit 4a03197 into main Feb 17, 2023
@inon-man
Copy link
Collaborator Author

inon-man commented Feb 18, 2023 via email

@inon-man inon-man deleted the panic-at-columbus-genesis branch February 18, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants