Skip to content

Commit

Permalink
Merge branch 'main' into vaggelis/sdk-1780-clerkremix-v4012-requestin…
Browse files Browse the repository at this point in the history
…it-duplex-option-is-required-when
  • Loading branch information
anagstef committed Jun 14, 2024
2 parents 4d7a407 + b8acf30 commit f6fb0eb
Show file tree
Hide file tree
Showing 29 changed files with 1,398 additions and 431 deletions.
2 changes: 2 additions & 0 deletions .changeset/long-queens-promise.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
---
---
2 changes: 2 additions & 0 deletions .changeset/old-weeks-hammer.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
---
---
12 changes: 12 additions & 0 deletions .changeset/six-lobsters-happen.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
---
'@clerk/elements': minor
---

The `path` prop on the `<SignIn.Root>` and `<SignUp.Root>` component is now automatically inferred. Previously, the default values were `/sign-in` and `/sign-up`, on other routes you had to explicitly define your route.

The new heuristic for determining the path where `<SignIn.Root>` and `<SignUp.Root>` are mounted is:

1. `path` prop
2. Automatically inferred
3. If it can't be inferred, fallback to `CLERK_SIGN_IN_URL` and `CLERK_SIGN_UP_URL` env var
4. Fallback to `/sign-in` and `/sign-up`
7 changes: 7 additions & 0 deletions .changeset/tricky-rabbits-sparkle.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@clerk/clerk-js": patch
---

In a previous release the protocol validation for window navigation was added ([ref](https://github.com/clerk/javascript/commit/b91e0ef4036d215da09d144f85b0a5ef2afe6cba)). Since then only `http:` and `https:` were allowed.

With this release `wails:` is also supported again. If you think that the mentioned commit introduced a regression for you and your protocol should be supported, please open an issue.
6 changes: 3 additions & 3 deletions integration/tests/handshake.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { generateConfig, getJwksFromSecretKey } from '../testUtils/handshake';

const PORT = 4199;

test.describe('Client handshake @generic', () => {
test.skip('Client handshake @generic', () => {
test.describe.configure({ mode: 'serial' });

let app: Application;
Expand Down Expand Up @@ -42,7 +42,7 @@ test.describe('Client handshake @generic', () => {
// Set the paths that don't require the user to be signed in
const publicPaths = ['/', /^(\\/(sign-in|sign-up|app-dir|custom)\\/*).*$/];
export const middleware = (req, evt) => {
return authMiddleware({
publicRoutes: publicPaths,
Expand All @@ -54,7 +54,7 @@ test.describe('Client handshake @generic', () => {
signInUrl: req.headers.get("x-sign-in-url"),
})(req, evt)
};
export const config = {
matcher: ['/((?!.+\\.[\\w]+$|_next).*)', '/', '/(api|trpc)(.*)'],
};
Expand Down
Loading

0 comments on commit f6fb0eb

Please sign in to comment.