(open-telemetry#9297)

- refactor constructor to static method
cleverchuk · Oct 26, 2023 · 744d15d · 744d15d
1 parent 87b61ae
commit 744d15d
Showing 1 changed file with 14 additions and 7 deletions.
diff --git a/...entelemetry/instrumentation/log4j/contextdata/v2_17/OpenTelemetryContextDataProvider.java b/...entelemetry/instrumentation/log4j/contextdata/v2_17/OpenTelemetryContextDataProvider.java
@@ -27,21 +27,28 @@
  */
 public class OpenTelemetryContextDataProvider implements ContextDataProvider {
 
-  private boolean configuredResourceAttributeAccessible;
+  private static final boolean BAGGAGE_ENABLED =
+      ConfigPropertiesUtil.getBoolean("otel.instrumentation.log4j-context-data.add-baggage", false);
+
+  private static final boolean configuredResourceAttributeAccessible =
+      isConfiguredResourceAttributeAccessible();
 
-  public OpenTelemetryContextDataProvider() {
+  /**
+   * Checks whether {@link ConfiguredResourceAttributesHolder} is available in classpath. The result
+   * is true if {@link ConfiguredResourceAttributesHolder} can be loaded, false otherwise.
+   *
+   * @return A boolean
+   */
+  private static boolean isConfiguredResourceAttributeAccessible() {
     try {
       Class.forName("io.opentelemetry.javaagent.bootstrap.ConfiguredResourceAttributesHolder");
-      this.configuredResourceAttributeAccessible = true;
+      return true;
 
     } catch (ClassNotFoundException ok) {
-      this.configuredResourceAttributeAccessible = false;
+      return false;
     }
   }
 
-  private static final boolean BAGGAGE_ENABLED =
-      ConfigPropertiesUtil.getBoolean("otel.instrumentation.log4j-context-data.add-baggage", false);
-
   /**
    * Returns context from the current span when available.
    *