-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Abort callback order #517
Comments
Yes, I am aware of that glitch, but was unsure of what to do in the case of a transaction failing in the middle of a single (of many) commit plugins. |
Hello @olofhagsand, |
OK, lets add a new callback. |
yep, would like to follow with the PR. Do I need to create separate issue for the PR? |
Yes, maybe you could add a separate issue to describe what to add and then reference that from a PR. |
@olofhagsand I've created new PR w/ reference on this discussion |
Hello team,
Is there any way to make clixon backend to run abort callback before revert?
Let me describe my concern in more details, we have 4 plugins, e.g.
PLUGIN 1
PLUGIN 2
PLUGIN 3
PLUGIN 4
that run in the appropriate order.
Let's say PLUGIN 4's commit callback fails with error:
Then backend starts in reverse order revert callbacks and then abort callbacks:
Revert callbacks run only for "successfully commited" plugins starting from PLUGIN 3->2->1.
But in case PLUGIN 4 managed to leave any "print" on the system before it failed and from data/yang model prospective has references on previous plugins then we have to make some operations to clear that "print" before revert operations for PLUGIN 3->2->1 ,
but we don't have any place holder for that.
The text was updated successfully, but these errors were encountered: