Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement User-side Config for Build Tasks (ZAP scans, et al) #4261

Closed
1 task
Tracked by #4327
drewbo opened this issue Oct 2, 2023 · 3 comments · Fixed by #4531
Closed
1 task
Tracked by #4327

Implement User-side Config for Build Tasks (ZAP scans, et al) #4261

drewbo opened this issue Oct 2, 2023 · 3 comments · Fixed by #4531
Assignees

Comments

@drewbo
Copy link
Contributor

drewbo commented Oct 2, 2023

Decide how configuration of a build task should be handled in the UI + task itself.

Acceptance Criteria

  • Determine next steps and acceptance criteria
@drewbo drewbo self-assigned this Oct 16, 2023
@drewbo drewbo changed the title Implement API and Config for ZAP Build Task scans Implement Config for ZAP Build Task scans Oct 30, 2023
@apburnes
Copy link
Contributor

Defer to a later date once we have user data on how the build tasks could be configurable.

@sknep sknep changed the title Implement Config for ZAP Build Task scans Implement User-side Config for Build Tasks (ZAP scans, et al) Nov 27, 2023
@sknep
Copy link
Contributor

sknep commented Nov 27, 2023

See #4170 and #4171

Site settings page

@drewbo drewbo removed their assignment Apr 3, 2024
@drewbo drewbo self-assigned this May 30, 2024
drewbo added a commit to cloud-gov/pages-cf-build-tasks that referenced this issue Jun 7, 2024
@drewbo
Copy link
Contributor Author

drewbo commented Jun 7, 2024

Two WIP PRs up for this:

  • Feat build scan config #4531 implements the ability for users to configure their scan rules at site/:id/scan-config. The functionality is there and it could use a healthy does of styling
  • Use scan configuration pages-cf-build-tasks#33 adds the supplied configuration to the scans and changes the data processing to ignore rules as specified. It does not yet change the rendering of the reports

cc: @sknep

drewbo added a commit to cloud-gov/pages-cf-build-tasks that referenced this issue Jun 11, 2024
drewbo added a commit that referenced this issue Jun 12, 2024
drewbo added a commit that referenced this issue Jun 12, 2024
drewbo added a commit that referenced this issue Jun 12, 2024
drewbo added a commit that referenced this issue Jun 14, 2024
drewbo added a commit that referenced this issue Jun 14, 2024
drewbo added a commit that referenced this issue Jun 14, 2024
@sknep sknep self-assigned this Jun 17, 2024
drewbo added a commit to cloud-gov/pages-cf-build-tasks that referenced this issue Jun 18, 2024
drewbo added a commit that referenced this issue Jun 18, 2024
drewbo added a commit that referenced this issue Jun 18, 2024
drewbo added a commit that referenced this issue Jun 18, 2024
sknep pushed a commit that referenced this issue Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants