Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R=2^32 ? #365

Closed
kriskwiatkowski opened this issue Aug 14, 2022 · 2 comments · Fixed by #366
Closed

R=2^32 ? #365

kriskwiatkowski opened this issue Aug 14, 2022 · 2 comments · Fixed by #366

Comments

@kriskwiatkowski
Copy link
Contributor

kriskwiatkowski commented Aug 14, 2022 •
edited
Loading

Shouldn't this be?
(256)⁻¹ R² mod q, where R = 2³²

> sage -c "Q=8380417;L=32;R=2^L;print((R^2)/(2^8)%Q)"
41978

circl/sign/dilithium/internal/common/params/params.go

Line 12 in 0a9554f

ROver256 = 41978 // = (256)⁻¹ R², where R = q mod 2³²

bwesterb added a commit that referenced this issue Aug 14, 2022
@bwesterb
dilithium: minor clarification
2bc8b0b 
Closes #365
bwesterb added a commit that referenced this issue Aug 14, 2022
@bwesterb
dilithium: minor clarification
47dc03d 
Closes #365
bwesterb added a commit that referenced this issue Aug 14, 2022
@bwesterb
dilithium: fix typo
165d23f 
Closes #365
@bwesterb bwesterb mentioned this issue Aug 14, 2022
Merged
@bwesterb
Copy link
Member

Yeah, that's a typo.

@kriskwiatkowski
Copy link
Contributor Author

Thank you. I started to think, I'm missing something here.

armfazh pushed a commit that referenced this issue Aug 15, 2022
@bwesterb @armfazh
dilithium: fix typo
39ba87a 
Closes #365
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dilithium: fix typo cloudflare/circl
2 participants
@bwesterb @kriskwiatkowski