Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pad blind RSA protocol messages to fixed modulus width #310

Merged
merged 1 commit into from
Jan 3, 2022

Conversation

chris-wood
Copy link
Contributor

Before, some messages would contain |N|-1 bytes, and the spec requires the endpoints to abort in that case. This change ensures that all protocol messages are of the appropriate fixed width.

Copy link
Contributor

@cjpatton cjpatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty subtle, so it's worth adding a test that enforces it.

blindsign/blindrsa/blindrsa.go Outdated Show resolved Hide resolved
@chris-wood
Copy link
Contributor Author

@cjpatton added tests for the lengths!

Also check that the encoded message from the test vectors matches expectation.
@armfazh armfazh merged commit 15f3904 into master Jan 3, 2022
@armfazh armfazh deleted the caw/pad-messages branch January 3, 2022 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants